Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 506143003: Mark some member variables as "const". (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@aesctr
Project:
chromium
Visibility:
Public.

Description

Mark some member variables as "const". Committed: https://crrev.com/cd142598505042c440064faad5b7b1039a7577da Cr-Commit-Position: refs/heads/master@{#292196}

Patch Set 1 #

Patch Set 2 : should -> must #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/child/webcrypto/algorithm_registry.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
eroman@chromium.org changed reviewers: + rsleevi@chromium.org
6 years, 3 months ago (2014-08-26 21:53:12 UTC) #1
eroman
(Squeezing out some minor CLs while sheriffing)
6 years, 3 months ago (2014-08-26 21:53:12 UTC) #2
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-08-27 17:11:01 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 3 months ago (2014-08-27 17:14:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/506143003/20001
6 years, 3 months ago (2014-08-27 17:15:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 18:17:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f71b70515bb184d641893377b29d2a7700354f03
6 years, 3 months ago (2014-08-27 18:52:43 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd142598505042c440064faad5b7b1039a7577da
Cr-Commit-Position: refs/heads/master@{#292196}

Powered by Google App Engine
This is Rietveld 408576698