Issue 50613003: Move the PolicyDomain and PolicyNamespace types to the policy component.

Issue 50613003: Move the PolicyDomain and PolicyNamespace types to the policy component. (Closed)

Created:
7 years, 1 month ago by Joao da Silva

Modified:
7 years, 1 month ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move the PolicyDomain and PolicyNamespace types to the policy component. Also refactored the files that use these types, so that they don't need to include the policy_service.h anymore. In some cases this was a circular dependency (e.g. PolicyBundle). BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231824

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -89 lines)			Patch
M	chrome/browser/chromeos/policy/device_local_account_policy_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/async_policy_loader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/component_cloud_policy_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/component_cloud_policy_store.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/component_cloud_policy_updater.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/policy_bundle.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/policy_bundle.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_domain_descriptor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/policy_service.h	View	1 chunk	+1 line, -33 lines	0 comments	Download
M	chrome/browser/policy/policy_service.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	components/policy.gypi	View	2 chunks	+7 lines, -7 lines	0 comments	Download
A	components/policy/core/common/policy_namespace.h	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	components/policy/core/common/policy_namespace.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download
D	components/policy/stub_to_remove.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

I think there are a lot more files where you can s/policy_service.h/policy_namespace.h/. I actually did ...

7 years, 1 month ago (2013-10-30 10:35:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/50613003/110001

7 years, 1 month ago (2013-10-30 10:47:42 UTC) #4

Message was sent while issue was closed.

Change committed as 231824

Expand Messages | Collapse Messages