Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 506113002: Add support for tracing in browser tests. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for tracing in browser tests. This CL adds support for collecting tracing data during the execution of browser tests. It is currently not possible to do so, yet it is very useful to be able to collect this data and analyze it without having to step through with debugger. BUG= Committed: https://crrev.com/047af26ba1bb8dd0cb74c132b2578eb91d8c7076 Cr-Commit-Position: refs/heads/master@{#292156}

Patch Set 1 #

Patch Set 2 : Clean up. #

Total comments: 1

Patch Set 3 : Fix alignment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M content/public/common/content_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 1 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nasko
nasko@chromium.org changed reviewers: + jam@chromium.org
6 years, 3 months ago (2014-08-26 22:16:53 UTC) #1
nasko
Hey John, Can you review this CL for me? Thanks, Nasko
6 years, 3 months ago (2014-08-26 22:16:53 UTC) #2
jam
lgtm, nice https://codereview.chromium.org/506113002/diff/20001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/506113002/diff/20001/content/public/common/content_switches.cc#newcode452 content/public/common/content_switches.cc:452: const char kEnableTracing[] = "enable-tracing"; nit: here ...
6 years, 3 months ago (2014-08-27 03:33:59 UTC) #3
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 3 months ago (2014-08-27 13:53:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/506113002/40001
6 years, 3 months ago (2014-08-27 13:54:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 14:55:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b61c74ca95d8c5e9d287baf3f2c5b60508081a62
6 years, 3 months ago (2014-08-27 15:34:56 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:49 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/047af26ba1bb8dd0cb74c132b2578eb91d8c7076
Cr-Commit-Position: refs/heads/master@{#292156}

Powered by Google App Engine
This is Rietveld 408576698