Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: mojo/application_manager/application_loader.h

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/application_loader.h
diff --git a/mojo/application_manager/application_loader.h b/mojo/application_manager/application_loader.h
index cf5cf967ef2d456765a6ef67aede27a3fd32ecb8..5e89a061c4a32557f74a949e704e4c0b677891fe 100644
--- a/mojo/application_manager/application_loader.h
+++ b/mojo/application_manager/application_loader.h
@@ -75,8 +75,9 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationLoader {
const GURL& url,
scoped_refptr<LoadCallbacks> callbacks) = 0;
- // TODO(davemoore): Change name to OnApplicationError.
- virtual void OnServiceError(ApplicationManager* manager, const GURL& url) = 0;
+ // Called when the Application exits.
+ virtual void OnApplicationError(ApplicationManager* manager,
+ const GURL& url) = 0;
protected:
ApplicationLoader() {}
« no previous file with comments | « no previous file | mojo/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698