mojo/application_manager/application_loader.h - Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application_manager/application_loader.h

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/application_manager/application_loader.h

diff --git a/mojo/application_manager/application_loader.h b/mojo/application_manager/application_loader.h

index cf5cf967ef2d456765a6ef67aede27a3fd32ecb8..8f06810d51bb72fc62c70a076499f90d07a4f4c5 100644

--- a/mojo/application_manager/application_loader.h

+++ b/mojo/application_manager/application_loader.h

@@ -76,7 +76,8 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationLoader {

scoped_refptr<LoadCallbacks> callbacks) = 0;

// TODO(davemoore): Change name to OnApplicationError.

tim (not reviewing) 2014/08/26 17:19:25 nit - remove TODO! Comment wouldn't hurt.

- virtual void OnServiceError(ApplicationManager* manager, const GURL& url) = 0;

+ virtual void OnApplicationError(ApplicationManager* manager,

+ const GURL& url) = 0;

protected:

ApplicationLoader() {}

« no previous file with comments | « no previous file | mojo/application_manager/application_manager.cc » ('j') | no next file with comments »