Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: mojo/shell/dynamic_application_loader.cc

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/shell/dynamic_application_loader.h ('k') | mojo/shell/network_application_loader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/shell/dynamic_application_loader.h" 5 #include "mojo/shell/dynamic_application_loader.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 it != runners_.end(); ++it) { 160 it != runners_.end(); ++it) {
161 if (*it == runner) { 161 if (*it == runner) {
162 runners_.erase(it); 162 runners_.erase(it);
163 if (!temp_file.empty()) 163 if (!temp_file.empty())
164 base::DeleteFile(temp_file, false); 164 base::DeleteFile(temp_file, false);
165 return; 165 return;
166 } 166 }
167 } 167 }
168 } 168 }
169 169
170 void DynamicApplicationLoader::OnServiceError(ApplicationManager* manager, 170 void DynamicApplicationLoader::OnApplicationError(ApplicationManager* manager,
171 const GURL& url) { 171 const GURL& url) {
172 // TODO(darin): What should we do about service errors? This implies that 172 // TODO(darin): What should we do about service errors? This implies that
173 // the app closed its handle to the service manager. Maybe we don't care? 173 // the app closed its handle to the service manager. Maybe we don't care?
174 } 174 }
175 175
176 } // namespace shell 176 } // namespace shell
177 } // namespace mojo 177 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/shell/dynamic_application_loader.h ('k') | mojo/shell/network_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698