content/child/service_worker/service_worker_registration_handle_reference.cc - Issue 506093002: Remove implicit conversions from scoped_refptr to T* in content/*/service_worker/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_registration_handle_reference.cc

Issue 506093002: Remove implicit conversions from scoped_refptr to T* in content/*/service_worker/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_cache.cc ('K') | « content/child/service_worker/service_worker_provider_context.cc ('k') | content/child/service_worker/web_service_worker_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_registration_handle_reference.cc

diff --git a/content/child/service_worker/service_worker_registration_handle_reference.cc b/content/child/service_worker/service_worker_registration_handle_reference.cc

index dfbbe2144b6e6a928a75290e5ef2c7b6c08c5eab..438bce486c0de95ad2dfed8a82592a69c63d0af6 100644

--- a/content/child/service_worker/service_worker_registration_handle_reference.cc

+++ b/content/child/service_worker/service_worker_registration_handle_reference.cc

@@ -33,7 +33,7 @@ ServiceWorkerRegistrationHandleReference(

: info_(info),

sender_(sender) {

DCHECK_NE(kInvalidServiceWorkerRegistrationHandleId, info_.handle_id);

- DCHECK(sender_);

+ DCHECK(sender_.get());

if (increment_ref_in_ctor)

return;

sender_->Send(