Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 506093002: Remove implicit conversions from scoped_refptr to T* in content/*/service_worker/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index 2f691a91e6d682536284aa06ce4a26289ab8c3c1..7c23e935a5a528796b36f9de73e7674c0e15509f 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -1123,21 +1123,21 @@ TEST_F(ServiceWorkerJobTest, Update_NewestVersionChanged) {
ServiceWorkerVersion* active_version = registration->active_version();
// Queue an Update, it should abort when it starts and sees the new version.
- job_coordinator()->Update(registration);
+ job_coordinator()->Update(registration.get());
// Add a waiting version with new script.
scoped_refptr<ServiceWorkerVersion> version =
- new ServiceWorkerVersion(registration,
+ new ServiceWorkerVersion(registration.get(),
GURL("http://www.example.com/new_worker.js"),
2L /* dummy version id */,
helper_->context()->AsWeakPtr());
- registration->SetWaitingVersion(version);
+ registration->SetWaitingVersion(version.get());
base::RunLoop().RunUntilIdle();
// Verify the registration was not modified by the Update.
EXPECT_EQ(active_version, registration->active_version());
- EXPECT_EQ(version, registration->waiting_version());
+ EXPECT_EQ(version.get(), registration->waiting_version());
EXPECT_EQ(NULL, registration->installing_version());
}
@@ -1166,7 +1166,7 @@ TEST_F(ServiceWorkerJobTest, Update_UninstallingRegistration) {
SaveUnregistration(SERVICE_WORKER_OK, &called));
// Update should abort after it starts and sees uninstalling.
- job_coordinator()->Update(registration);
+ job_coordinator()->Update(registration.get());
EXPECT_FALSE(called);
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698