Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 506075: Revert 34951 - Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.... (Closed)

Created:
11 years ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)
Visibility:
Public.

Description

Revert 34951 - Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC. The combined IPC means that scrolling only requires one transport DIB instead of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels for the exposed region, and then we'd use a second one in the PaintRect IPC to pass up the pixels for the updated scroll bar rendering. Now all paints are done using a single transport DIB. Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions. This means calling GetUpdateRgn and GetRegionData to enumerate the list of damage rects. Then only those rects are copied from the backing store. The same optimization is not done for Linux or Mac yet. R=brettw BUG=29591 TEST=none Review URL: http://codereview.chromium.org/506013 TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -376 lines) Patch
M chrome/browser/renderer_host/backing_store.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.mm View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/backing_store_win.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/backing_store_x.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_helper.h View 6 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_helper.cc View 6 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 10 chunks +68 lines, -27 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 8 chunks +50 lines, -51 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 5 chunks +37 lines, -56 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/common/render_messages.h View 7 chunks +76 lines, -35 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/renderer/render_widget.h View 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/renderer/render_widget.cc View 11 chunks +110 lines, -71 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
11 years ago (2009-12-18 15:52:47 UTC) #1
Robert Sesek
11 years ago (2009-12-18 15:55:32 UTC) #2
Chromium XP : compile failed. [ stdio stdio_html unit_tests - 2 error(s)
warnings ]
Chromium Linux : compile failed. [ stdio ]
Chromium Linux x64 : compile failed. [ stdio ]
Chromium Builder : compile failed. [ stdio ]
Chromium Mac Builder : update scripts failed. [ stdio ]
Chromium Mac Builder : compile failed. [ stdio ]
Linux Perf : compile failed. [ stdio ]
Modules Linux : compile failed. [ stdio ]
Linux Builder (ChromiumOS) : compile failed. [ stdio ]
Chromium Linux Builder (valgrind) : compile failed. [ stdio ]

distcc[23682] ERROR: compile
/home/chrome-bot/.ccache/render_vie.tmp.codf149.23601.ii on
codf1.jail.google.com:3633/6 failed
/b/slave/chromium-rel-linux/build/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc:
In member function 'virtual void
RenderViewHostTest_BadMessageHandlerRenderWidgetHost_Test::TestBody()':
/b/slave/chromium-rel-linux/build/src/chrome/browser/renderer_host/test/render_view_host_unittest.cc:41:
error: 'ViewHostMsg_PaintRect' has not been declared

Powered by Google App Engine
This is Rietveld 408576698