Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 506073002: Rename HostZoomMap::GetForBrowserContext() to GetDefaultForBrowserContext(). (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, creis+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename HostZoomMap::GetForBrowserContext() to GetDefaultForBrowserContext(). HostZoomMap will be moving from BrowserContext to StoragePartition soon as part of fixing this bug. Many sites will still want to access the default HostZoomMap for a BrowserContext, so we will rename this function in order to be clear about that. BUG=335317 Committed: https://crrev.com/f9b6ec8dbfbeb21efadd970ccf11889ef580a751 Cr-Commit-Position: refs/heads/master@{#292147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -45 lines) Patch
M chrome/browser/profiles/host_zoom_map_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/host_zoom_map_impl.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/host_zoom_map.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
wjmaclean
wjmaclean@chromium.org changed reviewers: + jam@chromium.org
6 years, 3 months ago (2014-08-26 17:35:23 UTC) #1
wjmaclean
jam@ - This is a very simple function re-naming CL in preparation for migrating HostZoomMaps ...
6 years, 3 months ago (2014-08-26 17:35:23 UTC) #2
jam
lgtm
6 years, 3 months ago (2014-08-27 03:38:19 UTC) #3
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 3 months ago (2014-08-27 12:46:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/506073002/1
6 years, 3 months ago (2014-08-27 12:46:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 14:02:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as eda34589a11f662b863890fe3dc6f1a63d652338
6 years, 3 months ago (2014-08-27 14:33:33 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9b6ec8dbfbeb21efadd970ccf11889ef580a751
Cr-Commit-Position: refs/heads/master@{#292147}

Powered by Google App Engine
This is Rietveld 408576698