Issue 506072: Don't push scoped refptr's onto the stack in plugin_channel_base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 506072: Don't push scoped refptr's onto the stack in plugin_channel_base. (Closed)

Created:
11 years ago by Craig

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Don't push scoped refptr's onto the stack in plugin_channel_base. This is one of the earlier variants of http://codereview.chromium.org/375005 and it fixes flash renderer crashes seen with gcc 4.4. BUG=28749, 30539 TEST=no errors under valgrind and no sad tab when loading https gmail [Closed, not committed since http://codereview.chromium.org/548011 is better and addresses the actual problem]

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/plugin/plugin_channel_base.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download