Issue 506069: [Mac] Port browser action popup test to mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506069: [Mac] Port browser action popup test to mac. (Closed)

Created:
11 years ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Bons

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Port browser action popup test to mac. BUG=29710 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35020

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -51 lines)			Patch
M	base/gfx/size.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	base/gfx/size.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/extension_popup_controller.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/extension_popup_controller.mm	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_apitest.cc	View	1	3 chunks	+29 lines, -51 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util.h	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util_mac.mm	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util_views.cc	View	1	2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

+andybons for more review. Andy did the Mac browser actions stuff. http://codereview.chromium.org/506069/diff/1/5 File chrome/browser/extensions/browser_action_test_util.h (right): ...

11 years ago (2009-12-18 17:52:39 UTC) #2

Bons

11 years ago (2009-12-18 21:28:59 UTC) #3

LGTM

Nits below.

http://codereview.chromium.org/506069/diff/1/9
File chrome/browser/cocoa/extensions/extension_popup_controller.mm (right):

http://codereview.chromium.org/506069/diff/1/9#newcode197
chrome/browser/cocoa/extensions/extension_popup_controller.mm:197: // Private
(TestingAPI)
For consistency, put a newline above or get rid of the newline after this block
below.

http://codereview.chromium.org/506069/diff/1/9#newcode200
chrome/browser/cocoa/extensions/extension_popup_controller.mm:200: return
minSize;
why not just

return {kMinWidth, kMinHeight};

or am I missing something?

Expand Messages | Collapse Messages