Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 506063002: Recorded additional tough_energy_cases. (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
tonyg, jeremy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PERF SHERIFF: This CL changes the tough_energy_cases test. Recorded additional tough_energy_cases. Moved all test cases to codepen, so they're easy to edit and all http. BUG=386152 Committed: https://crrev.com/d5753cc07e31db55895941e7679a2ea862e1c18d Cr-Commit-Position: refs/heads/master@{#292989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -28 lines) Patch
M tools/perf/page_sets/data/tough_energy_cases.json View 1 chunk +21 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 2 chunks +92 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sullivan
sullivan@chromium.org changed reviewers: + jeremy@chromium.org, tonyg@chromium.org
6 years, 3 months ago (2014-08-26 16:58:19 UTC) #1
sullivan
I've never updated a telemetry pageset before, so please take a careful look. A couple ...
6 years, 3 months ago (2014-08-26 16:58:19 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-08-26 17:30:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/506063002/1
6 years, 3 months ago (2014-09-02 18:14:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f4919a56f8dde79db10d158940bab9b5a95688f0
6 years, 3 months ago (2014-09-02 20:32:14 UTC) #6
sullivan
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/535153003/ by sullivan@chromium.org. ...
6 years, 3 months ago (2014-09-03 14:51:58 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5753cc07e31db55895941e7679a2ea862e1c18d
Cr-Commit-Position: refs/heads/master@{#292989}

Powered by Google App Engine
This is Rietveld 408576698