Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 506043002: (Reland) Service Worker: Handle same-scope, new script registration (Closed)

Created:
6 years, 3 months ago by falken
Modified:
6 years, 3 months ago
Reviewers:
michaeln, nhiroki
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

(Reland) Service Worker: Handle same-scope, new script registration Reland of 2da192aff after: - disabling some layout tests that need to be rebaselined - landing 6cce6b78f "Decouple script_url from ServiceWorkerRegistration" so Registration doesn't get in a weird state with a script_url that failed to register Before this patch, register() would delete an existing registration at the scope if the script URL didn't match, and register a new one. This overwriting creates a scenario where old tabs have a different controller than new tabs, which the Service Worker spec avoids. This patch implements the spec steps for same-scope, new script register(). That means: - If the existing registration is uninstalling, wait for that to complete before doing anything. - Create a new worker which becomes the installing worker of the existing registration. BUG=398355 TEST=https://codereview.chromium.org/480943002/ Committed: https://crrev.com/0b0c1c512f7a797a3f5ba679507109af87d12e1b Cr-Commit-Position: refs/heads/master@{#292106}

Patch Set 1 #

Patch Set 2 : fix whitespace #

Patch Set 3 : improve todo #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -65 lines) Patch
M content/browser/service_worker/service_worker_context_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 5 chunks +25 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 2 5 chunks +73 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 4 chunks +13 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 4 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
falken
falken@chromium.org changed reviewers: + michaeln@chromium.org, nhiroki@chromium.org
6 years, 3 months ago (2014-08-26 15:46:26 UTC) #1
falken
michaeln, nhiroki: PTAL. This is the same patch as https://codereview.chromium.org/472103003/ The differences are: - I'll ...
6 years, 3 months ago (2014-08-26 15:46:26 UTC) #2
michaeln
lgtm (i can pick up landing these patches if you like)
6 years, 3 months ago (2014-08-27 00:30:24 UTC) #3
falken
Thanks! I'll try to power through :) The Blink test expectations landed so I'll go ...
6 years, 3 months ago (2014-08-27 04:20:50 UTC) #4
falken
The CQ bit was checked by falken@chromium.org
6 years, 3 months ago (2014-08-27 04:21:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/506043002/60001
6 years, 3 months ago (2014-08-27 04:22:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 05:24:52 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (60001) as 21199494fb1a8adbf60cce5ae375a582e4d3204d
6 years, 3 months ago (2014-08-27 06:49:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:01 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0b0c1c512f7a797a3f5ba679507109af87d12e1b
Cr-Commit-Position: refs/heads/master@{#292106}

Powered by Google App Engine
This is Rietveld 408576698