Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: net/quic/quic_connection_helper_test.cc

Issue 50603015: QUIC - fix uninitialized reads in net::QuicCongestionManager::SetFromConfig (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | net/quic/quic_http_stream_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_helper_test.cc
diff --git a/net/quic/quic_connection_helper_test.cc b/net/quic/quic_connection_helper_test.cc
index d3d97e504f0d557f980e3754c8ebb278e93e68fa..159b20ae4ef602b51adafab1f5b4a8a90a4bba3d 100644
--- a/net/quic/quic_connection_helper_test.cc
+++ b/net/quic/quic_connection_helper_test.cc
@@ -133,6 +133,7 @@ class QuicConnectionHelperTest : public ::testing::Test {
QuicTime::Delta::FromMilliseconds(100)));
ON_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _))
.WillByDefault(Return(true));
+ ON_CALL(*send_algorithm_, SetFromConfig(_, _)).WillByDefault(Return());
Ryan Hamilton 2013/10/31 19:43:44 SetFromConfig is a void method, right? Can you do
ramant (doing other things) 2013/10/31 23:11:52 Done.
EXPECT_CALL(visitor_, HasPendingHandshake()).Times(AnyNumber());
writer_.reset(new QuicDefaultPacketWriter(socket_.get()));
connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_.get(),
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | net/quic/quic_http_stream_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698