Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: net/quic/quic_http_stream_test.cc

Issue 50603015: QUIC - fix uninitialized reads in net::QuicCongestionManager::SetFromConfig (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed ON_CALL to EXPECT_CALL Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_connection_helper_test.cc ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_http_stream.h" 5 #include "net/quic/quic_http_stream.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "net/base/net_errors.h" 9 #include "net/base/net_errors.h"
10 #include "net/base/test_completion_callback.h" 10 #include "net/base/test_completion_callback.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 EXPECT_CALL(*send_algorithm_, 191 EXPECT_CALL(*send_algorithm_,
192 OnPacketSent(_, _, _, _, _)).Times(AnyNumber()); 192 OnPacketSent(_, _, _, _, _)).Times(AnyNumber());
193 EXPECT_CALL(*send_algorithm_, RetransmissionDelay()).WillRepeatedly( 193 EXPECT_CALL(*send_algorithm_, RetransmissionDelay()).WillRepeatedly(
194 Return(QuicTime::Delta::Zero())); 194 Return(QuicTime::Delta::Zero()));
195 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _, _)). 195 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _, _)).
196 WillRepeatedly(Return(QuicTime::Delta::Zero())); 196 WillRepeatedly(Return(QuicTime::Delta::Zero()));
197 EXPECT_CALL(*send_algorithm_, SmoothedRtt()).WillRepeatedly( 197 EXPECT_CALL(*send_algorithm_, SmoothedRtt()).WillRepeatedly(
198 Return(QuicTime::Delta::Zero())); 198 Return(QuicTime::Delta::Zero()));
199 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly( 199 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly(
200 Return(QuicBandwidth::Zero())); 200 Return(QuicBandwidth::Zero()));
201 EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _)).Times(AnyNumber());
201 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_, 202 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_,
202 &random_generator_)); 203 &random_generator_));
203 writer_.reset(new QuicDefaultPacketWriter(socket)); 204 writer_.reset(new QuicDefaultPacketWriter(socket));
204 connection_ = new TestQuicConnection(guid_, peer_addr_, helper_.get(), 205 connection_ = new TestQuicConnection(guid_, peer_addr_, helper_.get(),
205 writer_.get()); 206 writer_.get());
206 connection_->set_visitor(&visitor_); 207 connection_->set_visitor(&visitor_);
207 connection_->SetSendAlgorithm(send_algorithm_); 208 connection_->SetSendAlgorithm(send_algorithm_);
208 connection_->SetReceiveAlgorithm(receive_algorithm_); 209 connection_->SetReceiveAlgorithm(receive_algorithm_);
209 crypto_config_.SetDefaults(); 210 crypto_config_.SetDefaults();
210 session_.reset( 211 session_.reset(
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 // priority. 725 // priority.
725 reliable_stream->SetDelegate(NULL); 726 reliable_stream->SetDelegate(NULL);
726 DCHECK_EQ(static_cast<QuicPriority>(kHighestPriority), 727 DCHECK_EQ(static_cast<QuicPriority>(kHighestPriority),
727 reliable_stream->EffectivePriority()); 728 reliable_stream->EffectivePriority());
728 reliable_stream->SetDelegate(delegate); 729 reliable_stream->SetDelegate(delegate);
729 } 730 }
730 731
731 } // namespace test 732 } // namespace test
732 733
733 } // namespace net 734 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection_helper_test.cc ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698