Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: net/quic/quic_connection_helper_test.cc

Issue 50603015: QUIC - fix uninitialized reads in net::QuicCongestionManager::SetFromConfig (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed ON_CALL to EXPECT_CALL Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection_helper.h" 5 #include "net/quic/quic_connection_helper.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "net/base/net_errors.h" 9 #include "net/base/net_errors.h"
10 #include "net/quic/crypto/quic_decrypter.h" 10 #include "net/quic/crypto/quic_decrypter.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 runner_ = new TestTaskRunner(&clock_); 124 runner_ = new TestTaskRunner(&clock_);
125 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_, 125 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_,
126 &random_generator_)); 126 &random_generator_));
127 send_algorithm_ = new testing::StrictMock<MockSendAlgorithm>(); 127 send_algorithm_ = new testing::StrictMock<MockSendAlgorithm>();
128 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _, _)). 128 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _, _)).
129 WillRepeatedly(Return(QuicTime::Delta::Zero())); 129 WillRepeatedly(Return(QuicTime::Delta::Zero()));
130 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly(Return( 130 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly(Return(
131 QuicBandwidth::FromKBitsPerSecond(100))); 131 QuicBandwidth::FromKBitsPerSecond(100)));
132 EXPECT_CALL(*send_algorithm_, SmoothedRtt()).WillRepeatedly(Return( 132 EXPECT_CALL(*send_algorithm_, SmoothedRtt()).WillRepeatedly(Return(
133 QuicTime::Delta::FromMilliseconds(100))); 133 QuicTime::Delta::FromMilliseconds(100)));
134 EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _)).Times(AnyNumber());
134 ON_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _)) 135 ON_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _))
135 .WillByDefault(Return(true)); 136 .WillByDefault(Return(true));
136 EXPECT_CALL(visitor_, HasPendingHandshake()).Times(AnyNumber()); 137 EXPECT_CALL(visitor_, HasPendingHandshake()).Times(AnyNumber());
137 writer_.reset(new QuicDefaultPacketWriter(socket_.get())); 138 writer_.reset(new QuicDefaultPacketWriter(socket_.get()));
138 connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_.get(), 139 connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_.get(),
139 writer_.get())); 140 writer_.get()));
140 connection_->set_visitor(&visitor_); 141 connection_->set_visitor(&visitor_);
141 connection_->SetSendAlgorithm(send_algorithm_); 142 connection_->SetSendAlgorithm(send_algorithm_);
142 } 143 }
143 144
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 Return(QuicTime::Delta::Zero())); 510 Return(QuicTime::Delta::Zero()));
510 EXPECT_CALL(visitor_, OnCanWrite()).WillOnce(Return(true)); 511 EXPECT_CALL(visitor_, OnCanWrite()).WillOnce(Return(true));
511 EXPECT_CALL(visitor_, HasPendingHandshake()).Times(AnyNumber()); 512 EXPECT_CALL(visitor_, HasPendingHandshake()).Times(AnyNumber());
512 runner_->RunNextTask(); 513 runner_->RunNextTask();
513 EXPECT_EQ(0u, connection_->NumQueuedPackets()); 514 EXPECT_EQ(0u, connection_->NumQueuedPackets());
514 EXPECT_TRUE(AtEof()); 515 EXPECT_TRUE(AtEof());
515 } 516 }
516 517
517 } // namespace test 518 } // namespace test
518 } // namespace net 519 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698