chrome/chrome_common.gypi - Issue 50603005: Add cross-platform API to get the form factor of the device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed files & variables, formatting change, added gypi exclusion of _desktop.cc Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 47750689bb675f91a14163a7444fe74b911d2770..40850a0aaf1dee2dd0e89ff6aa3e0838e7241d94 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -114,6 +114,10 @@

'common/custom_handlers/protocol_handler.cc',

'common/custom_handlers/protocol_handler.h',

'common/descriptors_android.h',

+ 'common/device_form_factor_android.cc',

+ 'common/device_form_factor_desktop.cc',

+ 'common/device_form_factor_ios.mm',

+ 'common/device_form_factor.h',

'common/dump_without_crashing.cc',

'common/dump_without_crashing.h',

'common/encrypted_media_messages_android.h',

@@ -505,6 +509,11 @@

'<(DEPTH)/webkit/glue/webkit_glue.gyp:glue',

}],

+ ['OS=="android" or OS=="ios"', {

+ 'sources!': [

+ 'common/device_form_factor_desktop.cc'

+ ],

+ }],

['OS=="android"', {

'sources/': [

['exclude', '^common/chrome_version_info_posix.cc'],

« no previous file with comments | « no previous file | chrome/common/device_form_factor.h » ('j') | chrome/common/device_form_factor.h » ('J')