chrome/common/device_form_factor_desktop.cc - Issue 50603005: Add cross-platform API to get the form factor of the device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/device_form_factor_desktop.cc

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Applied form factor API to other files Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/web_resource/notification_promo.cc ('K') | « chrome/common/device_form_factor_android.cc ('k') | chrome/common/device_form_factor_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/device_form_factor_desktop.cc

diff --git a/ui/base/cocoa/flipped_view.mm b/chrome/common/device_form_factor_desktop.cc

similarity index 60%

copy from ui/base/cocoa/flipped_view.mm

copy to chrome/common/device_form_factor_desktop.cc

index 57c16477a94b7b30f709bc71abbe10fe009b4ee8..cfe56eae84fc413eaf8208b9cb733798eae2bfb1 100644

--- a/ui/base/cocoa/flipped_view.mm

+++ b/chrome/common/device_form_factor_desktop.cc

@@ -2,12 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#import "ui/base/cocoa/flipped_view.h"

Alexei Svitkine (slow) 2013/10/31 14:52:32 This diff still looks weird. Maybe you can tweak g

Alexei Svitkine (slow) 2013/11/04 16:08:51 Ping.

+#include "device_form_factor.h"

-@implementation FlippedView

-- (BOOL)isFlipped {

- return YES;

+DeviceFormFactor GetDeviceFormFactor() {

+ return DEVICE_FORM_FACTOR_DESKTOP;

}

-@end

« chrome/browser/web_resource/notification_promo.cc ('K') | « chrome/common/device_form_factor_android.cc ('k') | chrome/common/device_form_factor_ios.mm » ('j') | no next file with comments »