ui/base/device_form_factor_ios.mm - Issue 50603005: Add cross-platform API to get the form factor of the device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/device_form_factor_ios.mm

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small formatting changes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/base/device_form_factor.h"

	6

	7 #import <UIKit/UIKit.h>

	8

	9 namespace ui {

	10

	11 DeviceFormFactor GetDeviceFormFactor() {

	12 UIUserInterfaceIdiom idiom = [[UIDevice currentDevice] userInterfaceIdiom];
	noyau (Ping after 24h) 2013/11/05 15:48:03 We currently use ios_ui_util::iPadIdiom() all over We currently use ios_ui_util::iPadIdiom() all over the place to to this check. We should pick one or the other to contain the canonical implementation and have the other one calling it. As the implementation in this file is cross-platform I suggest changing ios_ui_util::iPadIdiom() to call it. Alexei Svitkine (slow) 2013/11/05 16:27:28 Agreed. It will need to be done separately once th Show quoted text On 2013/11/05 15:48:03, noyau wrote: > We currently use ios_ui_util::iPadIdiom() all over the place to to this check. > > We should pick one or the other to contain the canonical implementation and have > the other one calling it. As the implementation in this file is cross-platform I > suggest changing ios_ui_util::iPadIdiom() to call it. Agreed. It will need to be done separately once this lands, since ios_ui_util::iPadIdiom() is not in the upstream repo.
	13 if (idiom == UIUserInterfaceIdiomPad)

	14 return DEVICE_FORM_FACTOR_TABLET;

	15 return DEVICE_FORM_FACTOR_PHONE;

	16 }

	17

	18 } // namespace ui

OLD	NEW

« chrome/browser/web_resource/notification_promo.cc ('K') | « ui/base/device_form_factor_desktop.cc ('k') | ui/base/ui_base_switches.h » ('j') | no next file with comments »