chrome/common/device_form_factor_android.cc - Issue 50603005: Add cross-platform API to get the form factor of the device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/device_form_factor_android.cc

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed files & variables, formatting change, added gypi exclusion of _desktop.cc Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "device_form_factor.h"

	6

	7 #include "base/command_line.h"

	8 #include "chrome/common/chrome_switches.h"

	9

	10 DeviceFormFactor GetDeviceFormFactor() {

	11 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUI)) {
	Alexei Svitkine (slow) 2013/10/29 20:25:05 There are several places that use this logic direc There are several places that use this logic directly. Can you update them to use the new API you're adding? yao 2013/10/29 22:44:13 Done. Show quoted text On 2013/10/29 20:25:05, Alexei Svitkine wrote: > There are several places that use this logic directly. Can you update them to > use the new API you're adding? Done.
	12 return Device_Form_Factor_TABLET;

	13 }

	14 return Device_Form_Factor_PHONE;

	15 }

OLD	NEW

« chrome/common/device_form_factor.h ('K') | « chrome/common/device_form_factor.h ('k') | chrome/common/device_form_factor_desktop.cc » ('j') | chrome/common/device_form_factor_desktop.cc » ('J')