chrome/common/device_form_factor.h - Issue 50603005: Add cross-platform API to get the form factor of the device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/device_form_factor.h

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed files & variables, formatting change, added gypi exclusion of _desktop.cc Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_DEVICE_FORM_FACTOR_H_

	6 #define CHROME_COMMON_DEVICE_FORM_FACTOR_H_

	7

	8 enum DeviceFormFactor {

	9 Device_Form_Factor_DESKTOP = 0,

	10 Device_Form_Factor_PHONE = 1,
	Alexei Svitkine (slow) 2013/10/29 20:25:05 Enums should be all caps (other than the ones gene Enums should be all caps (other than the ones generated from all protos). Check out Chromium C++ style guidelines: http://www.chromium.org/developers/coding-style yao 2013/10/29 22:44:13 Done. Show quoted text On 2013/10/29 20:25:05, Alexei Svitkine wrote: > Enums should be all caps (other than the ones generated from all protos). > > Check out Chromium C++ style guidelines: > http://www.chromium.org/developers/coding-style Done.
	11 Device_Form_Factor_TABLET = 2

	12 };

	13

	14 DeviceFormFactor GetDeviceFormFactor();

	15

	16 #endif // CHROME_COMMON_DEVICE_FORM_FACTOR_H_

OLD	NEW

« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/device_form_factor_android.cc » ('j') | chrome/common/device_form_factor_android.cc » ('J')