chrome/common/form_factor.h - Issue 50603005: Add cross-platform API to get the form factor of the device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/form_factor.h

Issue 50603005: Add cross-platform API to get the form factor of the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright
	Alexei Svitkine (slow) 2013/10/29 15:26:21 Use the following copyright blob (in all the files Use the following copyright blob (in all the files): // Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. yao 2013/10/29 19:21:57 Done. Show quoted text On 2013/10/29 15:26:21, Alexei Svitkine wrote: > Use the following copyright blob (in all the files): > > // Copyright 2013 The Chromium Authors. All rights reserved. > // Use of this source code is governed by a BSD-style license that can be > // found in the LICENSE file. Done.
	2

	3 #ifndef CHROME_COMMON_FORM_FACTOR_H_

	4 #define CHROME_COMMON_FORM_FACTOR_H_

	5

	6 enum Study_FormFactor {
	Alexei Svitkine (slow) 2013/10/29 15:26:21 This should be a different enum than the variation This should be a different enum than the variations Study protobuf ones. Let's use the following names: enum DeviceFormFactor { DEVICE_FORM_FACTOR_DESKTOP, DEVICE_FORM_FACTOR_PHONE, DEVICE_FORM_FACTOR_TABLET, }; DeviceFormFactor GetDeviceFormFactor(); Also, change the files to chrome/common/device_form_factor* (Sorry for changing my mind here since I originally told you to just use form_factor* names). yao 2013/10/29 19:21:57 Done. Show quoted text On 2013/10/29 15:26:21, Alexei Svitkine wrote: > This should be a different enum than the variations Study protobuf ones. > > Let's use the following names: > > enum DeviceFormFactor { > DEVICE_FORM_FACTOR_DESKTOP, > DEVICE_FORM_FACTOR_PHONE, > DEVICE_FORM_FACTOR_TABLET, > }; > > DeviceFormFactor GetDeviceFormFactor(); > > Also, change the files to chrome/common/device_form_factor* > > (Sorry for changing my mind here since I originally told you to just use > form_factor* names). Done.
	7 Study_FormFactor_DESKTOP = 0,

	8 Study_FormFactor_PHONE = 1,

	9 Study_FormFactor_TABLET = 2

	10 };

	11

	12 Study_FormFactor GetFormFactor();
	Alexei Svitkine (slow) 2013/10/29 15:26:21 Needs a comment. Mention that on non-Android, non- Needs a comment. Mention that on non-Android, non-IOS platforms, DEVICE_FORM_FACTOR_DESKTOP is always returned. yao 2013/10/29 19:21:57 Done. Show quoted text On 2013/10/29 15:26:21, Alexei Svitkine wrote: > Needs a comment. Mention that on non-Android, non-IOS platforms, > DEVICE_FORM_FACTOR_DESKTOP is always returned. Done.
	13

	14 #endif // CHROME_COMMON_FORM_FACTOR_H_

OLD	NEW

« chrome/chrome_common.gypi ('K') | « chrome/chrome_common.gypi ('k') | chrome/common/form_factor_android.cc » ('j') | chrome/common/form_factor_android.cc » ('J')