Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 506018: Merge r3397 to branches/1.3... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge r3397 to branches/1.3 The removal of the class TwoByteResource from test-strings.cc was not merged in as this class is still used on branches/1.3. A few changes (removal of #ifdef DEBUG/#endif in objects.h and objects-inl.h) from r3238 was also merged for the code to work. Finally the use of v8_str in test-string.h was changed to v8::String::New as v8_str was moved to cctest.h at some point after branches/1.3 was created. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -12 lines) Patch
M src/heap.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M test/cctest/test-strings.cc View 2 chunks +79 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
11 years ago (2009-12-15 22:00:03 UTC) #1
Kasper Lund
It seems that you're missing a change to version.cc. I don't know how you want ...
11 years ago (2009-12-16 05:55:10 UTC) #2
Mads Ager (chromium)
What Kasper said. Otherwise, LGTM.
11 years ago (2009-12-16 06:44:13 UTC) #3
Søren Thygesen Gjesse
11 years ago (2009-12-16 07:40:08 UTC) #4
On 2009/12/16 06:44:13, Mads Ager wrote:
> What Kasper said.  Otherwise, LGTM.

Updated version in r3469 and moved tag (deleted and re-created).

Powered by Google App Engine
This is Rietveld 408576698