Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 506013004: Improve the ScopedHandle verifier. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve the ScopedHandle verifier. 1. Automate the selection of the proper channel to enable the verifier. Now the code is enabled at runtime. 2. Switch to a hash_map to track handles. 3. Intercept CloseHandle to detect the code that is closing handles owned by ScopedHandles. The initial implementation only covers chrome.exe/dll, but the plan is to extend that in the future to all modules loaded in the process. BUG=362176 R=cpu@chromium.org R=sky@chromium.org See https://codereview.chromium.org/490043002/ for the actual review. TBR=cpu@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/1a4d07b227c51e2010867b3af70b2a58e7f01ad5 Cr-Commit-Position: refs/heads/master@{#291969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -31 lines) Patch
M base/win/scoped_handle.h View 3 chunks +13 lines, -6 lines 0 comments Download
M base/win/scoped_handle.cc View 4 chunks +92 lines, -7 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/app/close_handle_hook_win.h View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/app/close_handle_hook_win.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 4 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rvargas (doing something else)
I created a new CL to fix the base URL on Rietveld so that it ...
6 years, 3 months ago (2014-08-26 18:10:33 UTC) #1
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 3 months ago (2014-08-26 18:10:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/506013004/1
6 years, 3 months ago (2014-08-26 18:11:33 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 19:19:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as c928d0383db43f2f4baf8f9b24ed7454bf7eda64
6 years, 3 months ago (2014-08-26 19:46:13 UTC) #5
tonyg
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/507893002/ by tonyg@chromium.org. The ...
6 years, 3 months ago (2014-08-27 00:11:16 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a4d07b227c51e2010867b3af70b2a58e7f01ad5
Cr-Commit-Position: refs/heads/master@{#291969}

Powered by Google App Engine
This is Rietveld 408576698