Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 506003002: Minor-key-ify BinaryOpICWithAllocationSiteStub. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Minor-key-ify BinaryOpICWithAllocationSiteStub. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23444

Patch Set 1 #

Patch Set 2 : re-add GetExtraICState() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 3 chunks +9 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-08-26 13:09:14 UTC) #1
mvstanton
lgtm
6 years, 3 months ago (2014-08-26 14:52:49 UTC) #2
Yang
6 years, 3 months ago (2014-08-27 10:00:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698