Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 506003: Fix badge center-alignment logic.... (Closed)

Created:
11 years ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix badge center-alignment logic. This was initially fixed in r29152. It regressed in r30994. BUG=27648 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34513

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/extensions/extension_action.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
11 years ago (2009-12-14 23:14:34 UTC) #1
Finnur
On a general note: you need a TEST= statement. Apart from that, LGTM. On 2009/12/14 ...
11 years ago (2009-12-14 23:31:30 UTC) #2
Evan Stade
11 years ago (2009-12-14 23:34:51 UTC) #3
On 2009/12/14 23:31:30, Finnur wrote:
> On a general note: you need a TEST= statement.

done

> Apart from that, LGTM.
> 
> On 2009/12/14 23:14:34, Evan Stade wrote:
> >

Powered by Google App Engine
This is Rietveld 408576698