Issue 506003: Fix badge center-alignment logic....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506003: Fix badge center-alignment logic.... (Closed)

Created:
11 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix badge center-alignment logic. This was initially fixed in r29152. It regressed in r30994. BUG=27648 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34513

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/common/extensions/extension_action.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

On a general note: you need a TEST= statement. Apart from that, LGTM. On 2009/12/14 ...

11 years ago (2009-12-14 23:31:30 UTC) #2

Evan Stade

11 years ago (2009-12-14 23:34:51 UTC) #3

On 2009/12/14 23:31:30, Finnur wrote:
> On a general note: you need a TEST= statement.

done

> Apart from that, LGTM.
> 
> On 2009/12/14 23:14:34, Evan Stade wrote:
> >

Expand Messages | Collapse Messages