Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 505983002: HeapProfiler: remove obsolete AddImplicitReferences (Closed)

Created:
6 years, 3 months ago by loislo
Modified:
6 years, 3 months ago
Reviewers:
alph, yurys, marja
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

HeapProfiler: remove obsolete AddImplicitReferences it hasn't been used since r149579. More than one year ago. BUG= R=marja@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -42 lines) Patch
M src/global-handles.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/global-handles.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 3 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
loislo
loislo@chromium.org changed reviewers: + alph@chromium.org, yurys@chromium.org
6 years, 3 months ago (2014-08-26 11:36:17 UTC) #1
loislo
PTAL
6 years, 3 months ago (2014-08-26 11:36:17 UTC) #2
yurys
lgtm
6 years, 3 months ago (2014-08-26 11:41:38 UTC) #3
loislo
loislo@chromium.org changed reviewers: + marja@chromium.org
6 years, 3 months ago (2014-08-26 11:42:15 UTC) #4
loislo
6 years, 3 months ago (2014-08-26 11:42:15 UTC) #5
marja
lgtm, thanks! Looks like some leftover code indeed.
6 years, 3 months ago (2014-08-26 12:10:31 UTC) #6
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 3 months ago (2014-08-26 12:20:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/loislo@chromium.org/505983002/1
6 years, 3 months ago (2014-08-26 12:21:02 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 12:21:02 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-26 12:21:03 UTC) #10
marja
V8 doesn't have CQ. Do you need a V8 committer to land this?
6 years, 3 months ago (2014-08-26 12:56:29 UTC) #11
loislo
On 2014/08/26 12:56:29, marja wrote: > V8 doesn't have CQ. Do you need a V8 ...
6 years, 3 months ago (2014-08-26 12:59:19 UTC) #12
loislo
6 years, 3 months ago (2014-08-26 13:06:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as 23400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698