|
|
Chromium Code Reviews|
Created:
6 years, 3 months ago by dcheng Modified:
6 years, 3 months ago Reviewers:
willchan no longer on Chromium CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, Jeffrey Yasskin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionImplement the deference operator for scoped_refptr.
scoped_refptr previously got this for free since it implemented operator
T*, but the conversion operator is being removed. This prevents awkward
looking code like *my_favorite_pointer.get().
BUG=110610
Committed: https://crrev.com/4c2962cc5cf4301154bf475434b1400432c77527
Cr-Commit-Position: refs/heads/master@{#291869}
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
dcheng@chromium.org changed reviewers: + willchan@chromium.org
Unfortunately, quite a few scoped_refptr<> cleanup CLs have already landed that do *x.get(), so there will have to be a cleanup pass for those as well. Sigh.
LGTM
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
Message was sent while issue was closed.
Committed patchset #1 (1) as 71b93c14eff7ee9a58997fad294cea8a3b7459b1
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4c2962cc5cf4301154bf475434b1400432c77527 Cr-Commit-Position: refs/heads/master@{#291869} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
