Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 505943002: Implement the deference operator for scoped_refptr. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement the deference operator for scoped_refptr. scoped_refptr previously got this for free since it implemented operator T*, but the conversion operator is being removed. This prevents awkward looking code like *my_favorite_pointer.get(). BUG=110610 Committed: https://crrev.com/4c2962cc5cf4301154bf475434b1400432c77527 Cr-Commit-Position: refs/heads/master@{#291869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/memory/ref_counted.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + willchan@chromium.org
6 years, 3 months ago (2014-08-26 02:02:47 UTC) #1
dcheng
Unfortunately, quite a few scoped_refptr<> cleanup CLs have already landed that do *x.get(), so there ...
6 years, 3 months ago (2014-08-26 02:02:47 UTC) #2
willchan no longer on Chromium
LGTM
6 years, 3 months ago (2014-08-26 02:42:24 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 03:52:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
6 years, 3 months ago (2014-08-26 03:52:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 05:57:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 06:46:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/44025)
6 years, 3 months ago (2014-08-26 06:46:18 UTC) #8
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 07:13:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
6 years, 3 months ago (2014-08-26 07:13:45 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 07:43:34 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 08:08:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/44025)
6 years, 3 months ago (2014-08-26 08:08:34 UTC) #13
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 08:18:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505943002/1
6 years, 3 months ago (2014-08-26 08:19:35 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (1) as 71b93c14eff7ee9a58997fad294cea8a3b7459b1
6 years, 3 months ago (2014-08-26 08:37:46 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:30 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c2962cc5cf4301154bf475434b1400432c77527
Cr-Commit-Position: refs/heads/master@{#291869}

Powered by Google App Engine
This is Rietveld 408576698