Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest_delegate.h

Issue 505893002: Revert of Move core web_view code to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest_delegate.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
index 0b54e72b43e79dd5b81e20d577f0d2d1303b01f5..d72ae0ee6f5c4a46975d1cd48fd18b3761e2ca0b 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
@@ -14,8 +14,6 @@
namespace extensions {
-class WebViewGuest;
-
namespace api {
namespace web_view_internal{
@@ -27,7 +25,7 @@
// A delegate class of WebViewGuest that are not a part of chrome.
class WebViewGuestDelegate {
public :
- explicit WebViewGuestDelegate(WebViewGuest* web_view_guest);
+ WebViewGuestDelegate();
virtual ~WebViewGuestDelegate();
typedef std::vector<linked_ptr<api::web_view_internal::ContextMenuItem> >
@@ -41,9 +39,6 @@
// Called to attach helpers just after additional initialization is performed.
virtual void OnAttachWebViewHelpers(content::WebContents* contents) = 0;
-
- // Called to perform some cleanup prior to destruction.
- virtual void OnEmbedderDestroyed() = 0;
// Called when the guest WebContents commits a provisional load in any frame.
virtual void OnDidCommitProvisionalLoadForFrame(bool is_main_frame) = 0;
@@ -68,11 +63,7 @@
int request_id,
const MenuItemVector* items) = 0;
- WebViewGuest* web_view_guest() const { return web_view_guest_; }
-
private:
- WebViewGuest* const web_view_guest_;
-
DISALLOW_COPY_AND_ASSIGN(WebViewGuestDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698