Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: mojo/system/message_pipe_dispatcher_unittest.cc

Issue 505863002: Mojo: Add static factory functions to MessagePipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/message_pipe_dispatcher.cc ('k') | mojo/system/message_pipe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/message_pipe_dispatcher_unittest.cc
diff --git a/mojo/system/message_pipe_dispatcher_unittest.cc b/mojo/system/message_pipe_dispatcher_unittest.cc
index b31966b3c440747b96485fbb2c2b63ee36f128eb..2acb8cb6ceda2d1ed0b99d0028c1d2b749e7d2aa 100644
--- a/mojo/system/message_pipe_dispatcher_unittest.cc
+++ b/mojo/system/message_pipe_dispatcher_unittest.cc
@@ -43,7 +43,7 @@ TEST(MessagePipeDispatcherTest, Basic) {
scoped_refptr<MessagePipeDispatcher> d1(new MessagePipeDispatcher(
MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, i); // 0, 1.
d1->Init(mp, i ^ 1); // 1, 0.
}
@@ -148,7 +148,7 @@ TEST(MessagePipeDispatcherTest, InvalidParams) {
scoped_refptr<MessagePipeDispatcher> d1(
new MessagePipeDispatcher(MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, 0);
d1->Init(mp, 1);
}
@@ -179,7 +179,7 @@ TEST(MessagePipeDispatcherTest, InvalidParamsDeath) {
scoped_refptr<MessagePipeDispatcher> d1(
new MessagePipeDispatcher(MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, 0);
d1->Init(mp, 1);
}
@@ -223,7 +223,7 @@ TEST(MessagePipeDispatcherTest, BasicClosed) {
scoped_refptr<MessagePipeDispatcher> d1(new MessagePipeDispatcher(
MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, i); // 0, 1.
d1->Init(mp, i ^ 1); // 1, 0.
}
@@ -370,7 +370,7 @@ TEST(MessagePipeDispatcherTest, MAYBE_BasicThreaded) {
scoped_refptr<MessagePipeDispatcher> d1(new MessagePipeDispatcher(
MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, i); // 0, 1.
d1->Init(mp, i ^ 1); // 1, 0.
}
@@ -474,7 +474,7 @@ TEST(MessagePipeDispatcherTest, MAYBE_BasicThreaded) {
scoped_refptr<MessagePipeDispatcher> d1(new MessagePipeDispatcher(
MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d0->Init(mp, i); // 0, 1.
d1->Init(mp, i ^ 1); // 1, 0.
}
@@ -664,7 +664,7 @@ TEST(MessagePipeDispatcherTest, Stress) {
scoped_refptr<MessagePipeDispatcher> d_read(
new MessagePipeDispatcher(MessagePipeDispatcher::kDefaultCreateOptions));
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
d_write->Init(mp, 0);
d_read->Init(mp, 1);
}
« no previous file with comments | « mojo/system/message_pipe_dispatcher.cc ('k') | mojo/system/message_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698