Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 505853003: Work on GN build of Chrome. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
awong
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, erikwright+watch_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/64275214e0ab409050f048cb7e4b4cf30e3df082 Cr-Commit-Position: refs/heads/master@{#291952}

Patch Set 1 #

Total comments: 1

Patch Set 2 : additive #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -28 lines) Patch
M apps/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/policy/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/libgtk2ui/BUILD.gn View 1 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/BUILD.gn View 2 chunks +6 lines, -3 lines 0 comments Download
M components/copresence.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/copresence/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M components/signin/core/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 4 chunks +9 lines, -0 lines 0 comments Download
M components/usb_service/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_modal/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 3 chunks +10 lines, -8 lines 0 comments Download
M extensions/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/audio/BUILD.gn View 2 chunks +6 lines, -11 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libusb/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
brettw
brettw@chromium.org changed reviewers: + ajwong@chromium.org
6 years, 4 months ago (2014-08-26 00:23:14 UTC) #1
brettw
6 years, 4 months ago (2014-08-26 00:23:14 UTC) #2
awong
https://codereview.chromium.org/505853003/diff/1/chrome/browser/ui/libgtk2ui/BUILD.gn File chrome/browser/ui/libgtk2ui/BUILD.gn (right): https://codereview.chromium.org/505853003/diff/1/chrome/browser/ui/libgtk2ui/BUILD.gn#newcode60 chrome/browser/ui/libgtk2ui/BUILD.gn:60: if (!use_gconf) { Invert to be additive? The subtractive ...
6 years, 4 months ago (2014-08-26 00:29:04 UTC) #3
brettw
done, ptal
6 years, 4 months ago (2014-08-26 00:33:16 UTC) #4
awong
LGTM
6 years, 4 months ago (2014-08-26 00:34:02 UTC) #5
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 4 months ago (2014-08-26 00:45:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/505853003/60001
6 years, 4 months ago (2014-08-26 00:47:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-26 02:13:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 02:18:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6565) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/9291)
6 years, 4 months ago (2014-08-26 02:18:31 UTC) #10
brettw
Committed patchset #5 to pending queue manually as 624c50f.
6 years, 3 months ago (2014-08-26 19:07:23 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:29 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/64275214e0ab409050f048cb7e4b4cf30e3df082
Cr-Commit-Position: refs/heads/master@{#291952}

Powered by Google App Engine
This is Rietveld 408576698