Issue 505833002: Merge: Avatar Bubble doesn't re-pop when trying to click it away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505833002: Merge: Avatar Bubble doesn't re-pop when trying to click it away. (Closed)

Created:
6 years, 4 months ago by Roger Tawa OOO till Jul 10th

Modified:
6 years, 4 months ago

Reviewers:
Mike Lerman

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge: Avatar Bubble doesn't re-pop when trying to click it away. If the Avatar Bubble (profile chooser) is open and the Avatar Button is clicked, the bubble should disappear. BUG=402014 TBR=mlerman@chromium.org Review URL: https://codereview.chromium.org/488253002 Cr-Commit-Position: refs/heads/master@{#291260} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291260 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 9f8faa749db01ebcbe65b58266a1aede764910cd) Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/4e4cb2d

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	chrome/browser/ui/views/profiles/new_avatar_button.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/profiles/new_avatar_button.cc	View		3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

6 years, 4 months ago (2014-08-25 17:49:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 to pending queue manually as 4e4cb2d (presubmit
successful).

Expand Messages | Collapse Messages