Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 505783002: Revert of DevTools: Removed refcounting from AndroidWebSocket (Closed)

Created:
6 years, 4 months ago by vkuzkokov
Modified:
6 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Removed refcounting from AndroidWebSocket (patchset #12 of https://codereview.chromium.org/449883002/) Reason for revert: There is a crash when port forwarding is turned off while there is at least one connected device. BUG=407137 Original issue's description: > DevTools: Removed refcounting from AndroidWebSocket > > Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device. > > This requires for lifetime of AWS to be manageable in the first place. > > BUG=387067 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289306 Committed: https://crrev.com/5e3d07bf114469cb2cfe19f234b9ed704c89f6aa Cr-Commit-Position: refs/heads/master@{#291690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -259 lines) Patch
M chrome/browser/devtools/device/adb/adb_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/adb/adb_client_socket.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.h View 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.cc View 4 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/devtools/device/android_web_socket.cc View 5 chunks +108 lines, -157 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 9 chunks +30 lines, -25 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.cc View 11 chunks +46 lines, -27 lines 0 comments Download
M chrome/browser/devtools/device/self_device_provider.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/devtools/device/usb/usb_device_provider.cc View 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vkuzkokov
Created Revert of DevTools: Removed refcounting from AndroidWebSocket
6 years, 4 months ago (2014-08-25 14:35:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/505783002/1
6 years, 4 months ago (2014-08-25 14:36:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 14:36:03 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-25 14:36:04 UTC) #4
dgozman
lgtm
6 years, 4 months ago (2014-08-25 14:38:03 UTC) #5
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-25 14:38:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/505783002/1
6 years, 4 months ago (2014-08-25 14:39:14 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 15:33:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as af7f1d5c3ed8d793717970e962c7527820b5672e
6 years, 4 months ago (2014-08-25 16:09:21 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e3d07bf114469cb2cfe19f234b9ed704c89f6aa
Cr-Commit-Position: refs/heads/master@{#291690}

Powered by Google App Engine
This is Rietveld 408576698