Don't set document.domain to an IP address fragment.

Don't set document.domain to an IP address fragment.

Remove duplicated logic in Document.cpp and force the decision-making into
the existing weborigin/ code which makes the decision properly.

Adds a setting to permit tests that rely on 0.0.1 being a super-domain of 127.0.0.1.

BUG=312489
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161101

[Tom Sepez, 2013-10-29 22:06:49]

Adam, I really like this refactoring, since it solves a problem by removing
code, but the tests break.  I'm not sure I can come up with an equivalent scheme
for LayoutTests since we can't count on being in any particular domain.

[abarth-chromium, 2013-10-30 06:30:50]

This change is really good.  For the tests, maybe we want a setting that skips
the security checks for setting document.domain?

[Tom Sepez, 2013-10-30 23:27:40]

Adam, patchset 2 nearly resolves the issue with testing and IP addresses used as
domains.  But document-clone-node-change-domain.html creates documents ("doc",
"doc2" that do not appear to have associated settings() objects).  What's the
story with that?  Thanks!

[abarth-chromium, 2013-10-31 02:35:08]

On 2013/10/30 23:27:40, Tom Sepez wrote:
> Adam, patchset 2 nearly resolves the issue with testing and IP addresses used
as
> domains.  But document-clone-node-change-domain.html creates documents ("doc",
> "doc2" that do not appear to have associated settings() objects).  What's the
> story with that?  Thanks!

Yeah, frameless documents won't have a settings object.  It's ok to lose
coverage for that case.  LGTM

[commit-bot: I haz the power, 2013-10-31 20:34:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/50573004/150001

[commit-bot: I haz the power, 2013-10-31 21:11:11]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-31 21:43:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/50573004/340001

[commit-bot: I haz the power, 2013-10-31 23:24:59]

Change committed as 161101