Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 505723002: Revert of cc: Don't consider tiles at the layers raster_contents_scale incomplete (Closed)

Created:
6 years, 4 months ago by Finnur
Modified:
6 years, 3 months ago
Reviewers:
danakj, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, ajuma, brianderson, reveman
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Don't consider tiles at the layers raster_contents_scale incomplete (patchset #3 of https://codereview.chromium.org/484363003/) Reason for revert: Unit test added fails all the time. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/6770 Original issue's description: > cc: Don't consider tiles at the layers raster_contents_scale incomplete > > When PictureLayerImpl chooses a scale to raster at, we should accept > tiles at that scale as complete, and not try wait for tiles at some > other scale to be filled in. Such a tiling may not even exist. > > R=enne, vmpstr > BUG=406433 > > Committed: https://chromium.googlesource.com/chromium/src/+/60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f TBR=enne@chromium.org,vmpstr@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=406433 Committed: https://crrev.com/bb1bd87a4fad403340fe8e3168552a933954a535 Cr-Commit-Position: refs/heads/master@{#291653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -162 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -8 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +0 lines, -151 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
Created Revert of cc: Don't consider tiles at the layers raster_contents_scale incomplete
6 years, 4 months ago (2014-08-25 09:58:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/505723002/1
6 years, 4 months ago (2014-08-25 09:58:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as d23f154a47ffdfff2e198303057fa61ee1fe5031
6 years, 4 months ago (2014-08-25 09:59:16 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb1bd87a4fad403340fe8e3168552a933954a535
Cr-Commit-Position: refs/heads/master@{#291653}

Powered by Google App Engine
This is Rietveld 408576698