Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 505713004: Remove cc:LayerTreeHostImpl::IsContextLost. (Closed)

Created:
6 years, 4 months ago by dneto
Modified:
6 years, 3 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove cc:LayerTreeHostImpl::IsContextLost. The LTHI always notifies the scheduler of context loss. The single thread proxy no longer asks LTHI if the context is lost. In-flight composite actions just go ahead and draw. BUG=402511 Committed: https://crrev.com/b71e30c90d27b6af56e80db25236019d007b8055 Cr-Commit-Position: refs/heads/master@{#291783}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -55 lines) Patch
M cc/trees/layer_tree_host_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +1 line, -17 lines 1 comment Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -10 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +15 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
Oh wow no test changes needed anymore? Amaze. LGTM
6 years, 4 months ago (2014-08-25 17:01:30 UTC) #1
enne (OOO)
lgtm2. Thanks for letting my patch land first and rebaselining over top of it. https://codereview.chromium.org/505713004/diff/1/cc/trees/layer_tree_host_impl.cc ...
6 years, 4 months ago (2014-08-25 17:09:30 UTC) #2
dneto
On 2014/08/25 17:09:30, enne wrote: > lgtm2. Thanks for letting my patch land first and ...
6 years, 4 months ago (2014-08-25 21:16:13 UTC) #3
danakj
On 2014/08/25 21:16:13, dneto wrote: > On 2014/08/25 17:09:30, enne wrote: > > lgtm2. Thanks ...
6 years, 4 months ago (2014-08-25 21:17:30 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-25 21:17:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dneto@chromium.org/505713004/1
6 years, 4 months ago (2014-08-25 21:19:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 22:34:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (1) as 5c3095fc0ca59fe674375d45d09a1971e697ee52
6 years, 4 months ago (2014-08-25 23:27:29 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b71e30c90d27b6af56e80db25236019d007b8055
Cr-Commit-Position: refs/heads/master@{#291783}

Powered by Google App Engine
This is Rietveld 408576698