Adding histogram for measuing custom font collection loading latency and count.

Adding histogram for measuing custom font collection loading latency and count.

BUG=406659
R=isherman@chromium.org

Committed: https://crrev.com/71f99ec50add2a69658ca08462f0cbe8ab1bfc30
Cr-Commit-Position: refs/heads/master@{#292762}

[Ilya Sherman, 2014-08-27 00:56:30]

Where is the code that emits to this histogram?

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4068: +<histogram
name="DirectWrite.CountOfFontsToBeIgnored">
Is there any more general group where it would be appropriate to log these
histograms?  Maybe "DirectWrite" is appropriate; but often, using a more general
group name makes your histograms easier to find; and having fewer tiny groups
makes the dashboard easier to use.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4068: +<histogram
name="DirectWrite.CountOfFontsToBeIgnored">
Optional nit: Typically, a histogram like this would be named something more
like "DirectWrite.Fonts.Ignored" or something like that... but the longer name
is fine if you prefer it.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4071: +    Reports total number of fonts
that will be ignored while loading custom font
nit: "Reports total number of fonts" -> ""Reports the total number of fonts"

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4071: +    Reports total number of fonts
that will be ignored while loading custom font
nit: "while loading custom font collection" -> "while loading a custom font
collection" (unless I'm misunderstanding the intended meaning of the sentence?)

[Shrikant Kelkar, 2014-08-29 23:51:45]

I plan to create CL that uses these histograms after I fix names here. ptal.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4068: +<histogram
name="DirectWrite.CountOfFontsToBeIgnored">
On 2014/08/27 00:56:30, Ilya Sherman wrote:
> Optional nit: Typically, a histogram like this would be named something more
> like "DirectWrite.Fonts.Ignored" or something like that... but the longer name
> is fine if you prefer it.

Done.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4068: +<histogram
name="DirectWrite.CountOfFontsToBeIgnored">
On 2014/08/27 00:56:30, Ilya Sherman wrote:
> Is there any more general group where it would be appropriate to log these
> histograms?  Maybe "DirectWrite" is appropriate; but often, using a more
general
> group name makes your histograms easier to find; and having fewer tiny groups
> makes the dashboard easier to use.

It is close to Skia, but not part of it, would prefer to keep it separate as
it's final position could even change from renderer to browser.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4071: +    Reports total number of fonts
that will be ignored while loading custom font
On 2014/08/27 00:56:30, Ilya Sherman wrote:
> nit: "Reports total number of fonts" -> ""Reports the total number of fonts"

Done.

https://codereview.chromium.org/505683004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:4071: +    Reports total number of fonts
that will be ignored while loading custom font
On 2014/08/27 00:56:30, Ilya Sherman wrote:
> nit: "while loading custom font collection" -> "while loading a custom font
> collection" (unless I'm misunderstanding the intended meaning of the
sentence?)

Done.

[Ilya Sherman, 2014-08-30 00:47:51]

LGTM

[Shrikant Kelkar, 2014-08-30 01:02:41]

The CQ bit was checked by shrikant@chromium.org

[commit-bot: I haz the power, 2014-08-30 01:04:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shrikant@chromium.org/505683004/20001

[commit-bot: I haz the power, 2014-08-30 02:23:08]

Committed patchset #2 (id:20001) as cbc7a0105a06ebfa430ad32931facbd495101875

[commit-bot: I haz the power, 2014-09-10 03:13:25]

Patchset 2 (id:??) landed as
https://crrev.com/71f99ec50add2a69658ca08462f0cbe8ab1bfc30
Cr-Commit-Position: refs/heads/master@{#292762}