Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 50563008: Fixes for python 2.7.5 support. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, csharp, Vadim Sh.
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Fixes for python 2.7.5 support. Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore. The previous python wrapping scripts assumed python_bin\python.exe. This CL modifies the wrapping scripts to use python.bat. This requires some quoting magic and explicitly defer to cmd.exe. This may break some cases where double quotes are used as arguments. We can't do miracles on Windows. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=231888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M git-cl View 1 chunk +2 lines, -2 lines 0 comments Download
M git-try View 1 chunk +2 lines, -2 lines 0 comments Download
M pylint View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
Tested on both cmd.exe and cygwin. Used https://code.google.com/p/msysgit/issues/detail?id=426 as an inspiration. I know the quoting ...
7 years, 1 month ago (2013-10-29 20:29:48 UTC) #1
iannucci1
On 2013/10/29 20:29:48, M-A Ruel wrote: > Tested on both cmd.exe and cygwin. > Used ...
7 years, 1 month ago (2013-10-30 08:28:40 UTC) #2
M-A Ruel
On 2013/10/30 08:28:40, iannucci1 wrote: > On 2013/10/29 20:29:48, M-A Ruel wrote: > > Tested ...
7 years, 1 month ago (2013-10-30 13:05:01 UTC) #3
M-A Ruel
On 2013/10/30 13:05:01, M-A Ruel wrote: > On 2013/10/30 08:28:40, iannucci1 wrote: > > Won't ...
7 years, 1 month ago (2013-10-30 13:05:25 UTC) #4
iannucci
On 2013/10/30 13:05:25, M-A Ruel wrote: > On 2013/10/30 13:05:01, M-A Ruel wrote: > > ...
7 years, 1 month ago (2013-10-30 18:48:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/50563008/1
7 years, 1 month ago (2013-10-30 19:01:44 UTC) #6
commit-bot: I haz the power
Change committed as 231888
7 years, 1 month ago (2013-10-30 19:04:03 UTC) #7
M-A Ruel
7 years, 1 month ago (2013-10-30 20:04:32 UTC) #8
Message was sent while issue was closed.
On 2013/10/30 19:04:03, I haz the power (commit-bot) wrote:
> Change committed as 231888

Forgot to mention, it was for http://crbug.com/241769.

Powered by Google App Engine
This is Rietveld 408576698