Chromium Code Reviews
Help | Chromium Project | Sign in
(84)

Issue 5056004: Update the icons for the upgrade notification and the conflicts detected page... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Finnur
Modified:
3 years, 11 months ago
Reviewers:
Andrew T Wilson
CC:
chromium-reviews, ben+cc_chromium.org, Glen Murphy
Visibility:
Public.

Description

Update the icons for the upgrade notification and the conflicts detected page. Since we no longer pulsate the notification dot I've also removed the animation. BUG=http://crbug.com/51105, http://crbug.com/27941 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66412

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -98 lines) Patch
D chrome/app/theme/conflicts.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/conflicts_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 4 chunks +4 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 6 chunks +22 lines, -75 lines 2 comments Download
M chrome/browser/wrench_menu_model.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Finnur
Drew, since it looks like you are about to make modifications to this code, wanna ...
4 years, 6 months ago (2010-11-16 22:10:17 UTC) #1
Andrew T Wilson
LGTM, with one question. http://codereview.chromium.org/5056004/diff/6001/chrome/browser/ui/views/toolbar_view.cc File chrome/browser/ui/views/toolbar_view.cc (right): http://codereview.chromium.org/5056004/diff/6001/chrome/browser/ui/views/toolbar_view.cc#newcode685 chrome/browser/ui/views/toolbar_view.cc:685: 0 + kBadgeTopMargin); This is ...
4 years, 6 months ago (2010-11-17 03:31:32 UTC) #2
Finnur
4 years, 6 months ago (2010-11-17 09:18:51 UTC) #3
http://codereview.chromium.org/5056004/diff/6001/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/5056004/diff/6001/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar_view.cc:685: 0 + kBadgeTopMargin);
> Is this supposed to connote something special?

Yes, that I'm an idiot. :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be