extensions/extensions.gyp - Issue 505453002: Create dedicated class for handling wire message formatting and parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 505453002: Create dedicated class for handling wire message formatting and parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review feedback. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index f43aa1029903b8cebd78208496f6aad80f02927d..af4a3b8cf7539229691c7d52f3077d189eeff51d 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -298,6 +298,8 @@

'browser/api/cast_channel/cast_message_util.h',

'browser/api/cast_channel/cast_socket.cc',

'browser/api/cast_channel/cast_socket.h',

+ 'browser/api/cast_channel/cast_socket_framer.cc',

+ 'browser/api/cast_channel/cast_socket_framer.h',

mark a. foltz 2014/08/29 20:33:45 Are these files missing from the patch?

Kevin M 2014/08/29 23:18:27 Neglected to git add those files. Done.

'browser/api/cast_channel/logger.cc',

'browser/api/cast_channel/logger.h',

'browser/api/cast_channel/logger_util.cc',

« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket_unittest.cc ('k') | no next file » | no next file with comments »