Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: extensions/browser/api/cast_channel/cast_framer.cc

Issue 505453002: Create dedicated class for handling wire message formatting and parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resync to origin/master Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "extensions/browser/api/cast_channel/cast_framer.h"
6
7 #include <stdlib.h>
8
9 #include "base/numerics/safe_conversions.h"
10 #include "base/strings/string_number_conversions.h"
11 #include "base/sys_byteorder.h"
12 #include "extensions/browser/api/cast_channel/cast_channel.pb.h"
13
14 namespace extensions {
15 namespace core_api {
16 namespace cast_channel {
17 MessageFramer::MessageFramer(scoped_refptr<net::GrowableIOBuffer> input_buffer)
18 : input_buffer_(input_buffer), error_(false) {
19 Reset();
20 }
21
22 MessageFramer::~MessageFramer() {
23 }
24
25 MessageFramer::MessageHeader::MessageHeader() : message_size(0) {
26 }
27
28 void MessageFramer::MessageHeader::SetMessageSize(size_t size) {
29 DCHECK_LT(size, static_cast<size_t>(kuint32max));
30 DCHECK_GT(size, 0U);
31 message_size = size;
32 }
33
34 // TODO(mfoltz): Investigate replacing header serialization with base::Pickle,
35 // if bit-for-bit compatible.
36 void MessageFramer::MessageHeader::PrependToString(std::string* str) {
37 MessageHeader output = *this;
38 output.message_size = base::HostToNet32(message_size);
39 size_t header_size = MessageHeader::header_size();
40 scoped_ptr<char, base::FreeDeleter> char_array(
41 static_cast<char*>(malloc(header_size)));
42 memcpy(char_array.get(), &output, header_size);
43 str->insert(0, char_array.get(), header_size);
44 }
45
46 // TODO(mfoltz): Investigate replacing header deserialization with base::Pickle,
47 // if bit-for-bit compatible.
48 void MessageFramer::MessageHeader::Deserialize(char* data,
49 MessageHeader* header) {
50 uint32 message_size;
51 memcpy(&message_size, data, header_size());
52 header->message_size =
53 base::checked_cast<size_t>(base::NetToHost32(message_size));
54 }
55
56 // static
57 size_t MessageFramer::MessageHeader::header_size() {
58 return sizeof(uint32);
59 }
60
61 // static
62 size_t MessageFramer::MessageHeader::max_message_size() {
63 return 65535;
64 }
65
66 std::string MessageFramer::MessageHeader::ToString() {
67 return "{message_size: " +
68 base::UintToString(static_cast<uint32>(message_size)) + "}";
69 }
70
71 // static
72 bool MessageFramer::Serialize(const CastMessage& message_proto,
73 std::string* message_data) {
74 DCHECK(message_data);
75 message_proto.SerializeToString(message_data);
76 size_t message_size = message_data->size();
77 if (message_size > MessageHeader::max_message_size()) {
78 message_data->clear();
79 return false;
80 }
81 MessageHeader header;
82 header.SetMessageSize(message_size);
83 header.PrependToString(message_data);
84 return true;
85 }
86
87 size_t MessageFramer::BytesRequested() {
88 size_t bytes_left;
89 if (error_) {
90 return 0;
91 }
92
93 switch (current_element_) {
94 case HEADER:
95 bytes_left = MessageHeader::header_size() - message_bytes_received_;
96 DCHECK_LE(bytes_left, MessageHeader::header_size());
97 VLOG(2) << "Bytes needed for header: " << bytes_left;
98 return bytes_left;
99 case BODY:
100 bytes_left =
101 (body_size_ + MessageHeader::header_size()) - message_bytes_received_;
102 DCHECK_LE(
103 bytes_left,
104 MessageHeader::max_message_size() - MessageHeader::header_size());
105 VLOG(2) << "Bytes needed for body: " << bytes_left;
106 return bytes_left;
107 default:
108 NOTREACHED() << "Unhandled packet element type.";
109 return 0;
110 }
111 }
112
113 scoped_ptr<CastMessage> MessageFramer::Ingest(size_t num_bytes,
114 size_t* message_length,
115 ChannelError* error) {
116 LOG(ERROR) << "Ingest1";
117 DCHECK(error);
118 DCHECK(message_length);
119 if (error_) {
120 *error = CHANNEL_ERROR_INVALID_MESSAGE;
121 return scoped_ptr<CastMessage>();
122 }
123
124 DCHECK_EQ(base::checked_cast<int32>(message_bytes_received_),
125 input_buffer_->offset());
126 CHECK_LE(num_bytes, BytesRequested());
127 message_bytes_received_ += num_bytes;
128 *error = CHANNEL_ERROR_NONE;
129 *message_length = 0;
130 LOG(ERROR) << "Ingest2";
131 switch (current_element_) {
132 case HEADER:
133 LOG(ERROR) << "IngestHeader";
134 if (BytesRequested() == 0) {
135 MessageHeader header;
136 MessageHeader::Deserialize(input_buffer_.get()->StartOfBuffer(),
137 &header);
138 if (header.message_size > MessageHeader::max_message_size()) {
139 VLOG(1) << "Error parsing header (message size too large).";
140 *error = CHANNEL_ERROR_INVALID_MESSAGE;
141 error_ = true;
142 return scoped_ptr<CastMessage>();
143 }
144 current_element_ = BODY;
145 body_size_ = header.message_size;
146 }
147 break;
148 case BODY:
149 LOG(ERROR) << "IngestBody";
150 if (BytesRequested() == 0) {
151 LOG(ERROR) << "IngestBodyBytesRequestedIsZero";
152 scoped_ptr<CastMessage> parsed_message(new CastMessage);
153 if (!parsed_message->ParseFromArray(
154 input_buffer_->StartOfBuffer() + MessageHeader::header_size(),
155 body_size_)) {
156 LOG(ERROR) << "Couldn't parse packet body";
157 VLOG(1) << "Error parsing packet body.";
158 *error = CHANNEL_ERROR_INVALID_MESSAGE;
159 error_ = true;
160 return scoped_ptr<CastMessage>();
161 }
162 *message_length = body_size_;
163 Reset();
164 LOG(ERROR) << "Returning message";
165 return parsed_message.Pass();
166 }
167 break;
168 default:
169 NOTREACHED() << "Unhandled packet element type.";
170 return scoped_ptr<CastMessage>();
171 }
172
173 input_buffer_->set_offset(message_bytes_received_);
174 return scoped_ptr<CastMessage>();
175 }
176
177 void MessageFramer::Reset() {
178 current_element_ = HEADER;
179 message_bytes_received_ = 0;
180 body_size_ = 0;
181 input_buffer_->set_offset(0);
182 }
183
184 } // namespace cast_channel
185 } // namespace core_api
186 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.h ('k') | extensions/browser/api/cast_channel/cast_framer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698