Move DisownOpener to RenderFrameHost / RenderFrameProxyHost.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 762 matching lines @@
     IPC_MESSAGE_HANDLER(FrameMsg_Reload, OnReload)
     IPC_MESSAGE_HANDLER(FrameMsg_TextSurroundingSelectionRequest,
                         OnTextSurroundingSelectionRequest)
     IPC_MESSAGE_HANDLER(FrameMsg_AddStyleSheetByURL,
                         OnAddStyleSheetByURL)
     IPC_MESSAGE_HANDLER(FrameMsg_SetAccessibilityMode,
                         OnSetAccessibilityMode)
 #if defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(InputMsg_CopyToFindPboard, OnCopyToFindPboard)
 #endif
+    IPC_MESSAGE_HANDLER(FrameMsg_DisownOpener, OnDisownOpener)

[nasko, 2014/08/25 15:47:14]

nit: Don't put IPC handlers after the #ifdef'd ones.

[Charlie Reis, 2014/08/25 17:10:24]

Done.

   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 void RenderFrameImpl::OnNavigate(const FrameMsg_Navigate_Params& params) {
   MaybeHandleDebugURL(params.url);
   if (!render_view_->webview())
     return;
 
@@ skipping 361 matching lines @@
   // Since the find pasteboard supports only plain text, this can be simpler
   // than the |OnCopy()| case.
   if (frame_->hasSelection()) {
     base::string16 selection = frame_->selectionAsText();
     RenderThread::Get()->Send(
         new ClipboardHostMsg_FindPboardWriteStringAsync(selection));
   }
 }
 #endif
 
+void RenderFrameImpl::OnDisownOpener() {
+  if (frame_->opener())

[nasko, 2014/08/25 15:47:14]

Should we restrict this to main frames only? I'm not sure we have a clear
picture of what it means for a subframe to have an opener, so preserving
existing behavior might be desirable.
On the other hand, disowning an opener is "safer" operation since it will
disable operations, rather than enable, so I'm not quite sure which way is
better.

[Charlie Reis, 2014/08/25 17:10:24]

I've changed it to have a check and a TODO.  We'll need to move opener_ from
WebContents to FrameTreeNode before it makes sense to clear an opener on a
subframe.

+    frame_->setOpener(NULL);
+}
+
 void RenderFrameImpl::OnDelete() {
   frame_->executeCommand(WebString::fromUTF8("Delete"), GetFocusedElement());
 }
 
 void RenderFrameImpl::OnSelectAll() {
   base::AutoReset<bool> handling_select_range(&handling_select_range_, true);
   frame_->executeCommand(WebString::fromUTF8("SelectAll"), GetFocusedElement());
 }
 
 void RenderFrameImpl::OnSelectRange(const gfx::Point& start,
@@ skipping 2578 matching lines @@
 
 #if defined(ENABLE_BROWSER_CDMS)
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 #endif  // defined(ENABLE_BROWSER_CDMS)
 
 }  // namespace content