Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 505403003: app_shell: Add version number in user agent (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_shell: Add version number in user agent Some sites sniff the Chrome version number, so app_shell needs to provide one. BUG=407236 TEST=app_shell_unittests ShellContentClientTest.UserAgentFormat Committed: https://crrev.com/bf89045bff6e60d18bd91ae29c8e675db1d9ab6a Cr-Commit-Position: refs/heads/master@{#292063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/common/shell_content_client.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A extensions/shell/common/shell_content_client_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
jamescook@chromium.org changed reviewers: + derat@chromium.org
6 years, 3 months ago (2014-08-26 22:32:10 UTC) #1
James Cook
derat, PTAL
6 years, 3 months ago (2014-08-26 22:32:10 UTC) #2
Daniel Erat
lgtm
6 years, 3 months ago (2014-08-26 22:36:03 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 3 months ago (2014-08-26 23:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/505403003/1
6 years, 3 months ago (2014-08-26 23:02:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-27 00:15:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 40a0ec9559ed0993b0edbfe8cbcff15f1a40d082
6 years, 3 months ago (2014-08-27 01:17:10 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf89045bff6e60d18bd91ae29c8e675db1d9ab6a
Cr-Commit-Position: refs/heads/master@{#292063}

Powered by Google App Engine
This is Rietveld 408576698