Issue 505403002: Fix compiled action dependencies in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505403002: Fix compiled action dependencies in GN. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/4b04efb439a19c6dfef213a2fe51751b223f9cbd Cr-Commit-Position: refs/heads/master@{#292447}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -10 lines)			Patch
	M	build/compiled_action.gni	View		6 chunks	+18 lines, -1 line	0 comments	Download
	M	third_party/yasm/BUILD.gn	View	1	2 chunks	+11 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

brettw

brettw@chromium.org changed reviewers: + ajwong@chromium.org

6 years, 3 months ago (2014-08-26 22:30:06 UTC) #1

brettw

Committed patchset #2 (id:20001) to pending queue manually as b9af85a (presubmit successful).

6 years, 3 months ago (2014-08-28 20:24:54 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:01:41 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/4b04efb439a19c6dfef213a2fe51751b223f9cbd
Cr-Commit-Position: refs/heads/master@{#292447}