Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 505373002: Remove Extension Loaded/Unloaded notifications from LocationBarView(Mac) (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Extension Loaded/Unloaded notifications from LocationBarView(Mac) Having the views observe these notifications is strange -- they don't know when page actions are updated in any other ways, so they shouldn't need to know for this. Move the notifications to LocationBarController. Bonuses: - Less code! By 50 lines! - Remove four deprecated notification uses! This has a very loose dependency on https://codereview.chromium.org/508563003/. BUG=407672 Committed: https://crrev.com/5681e2f220f4bab29a5bd504dec15631eb8c1b4c Cr-Commit-Position: refs/heads/master@{#292225}

Patch Set 1 #

Patch Set 2 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -71 lines) Patch
M chrome/browser/extensions/location_bar_controller.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 4 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 4 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
rdevlin.cronin@chromium.org changed reviewers: + avi@chromium.org, finnur@chromium.org, pkasting@chromium.org
6 years, 3 months ago (2014-08-26 23:37:21 UTC) #1
Devlin
Finnur, Avi, and Peter, please take a look when you can. finnur: everything avi: c/b/ui/cocoa/ ...
6 years, 3 months ago (2014-08-26 23:37:21 UTC) #2
Avi (use Gerrit)
Cocoa lgtm
6 years, 3 months ago (2014-08-26 23:43:45 UTC) #3
Peter Kasting
LGTM
6 years, 3 months ago (2014-08-26 23:57:07 UTC) #4
Finnur
Moar moderniceing of koad! Woot! Woot! LGTM
6 years, 3 months ago (2014-08-27 11:35:36 UTC) #5
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 3 months ago (2014-08-27 20:03:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/505373002/20001
6 years, 3 months ago (2014-08-27 20:04:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 76c028bfb10ef771094a194378161ed1fb93439c
6 years, 3 months ago (2014-08-27 21:22:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5681e2f220f4bab29a5bd504dec15631eb8c1b4c
Cr-Commit-Position: refs/heads/master@{#292225}

Powered by Google App Engine
This is Rietveld 408576698