Issue 505353004: Webkitpy's version check should not throw any exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505353004: Webkitpy's version check should not throw any exception. (Closed)

Created:
6 years, 3 months ago by elecro

Modified:
6 years, 3 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Webkitpy's version check should not throw any exception. The python version checker inside the webkitpy uses Python 2 syntax to display the error message on the stderr. With Python 3 that code throws an error. Using directly the stderr as a file object will prevent the error. BUG=408166 TEST=webkit-patch -h Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180994