Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: athena/athena.gyp

Issue 505273002: Move app_shell specific impl from athena_lib to athena_shell_lib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/athena.gyp
diff --git a/athena/athena.gyp b/athena/athena.gyp
index 713c1d3b4136d710dee4ab7a6502e3eaced4be8a..467d7d809117f4003fc901e00ccb616bab8c2ae9 100644
--- a/athena/athena.gyp
+++ b/athena/athena.gyp
@@ -107,7 +107,6 @@
'../components/components.gyp:web_modal',
'../extensions/extensions.gyp:extensions_browser',
'../extensions/extensions.gyp:extensions_common',
- '../extensions/shell/app_shell.gyp:app_shell_lib',
'../content/content.gyp:content_browser',
'../ui/app_list/app_list.gyp:app_list',
'../ui/keyboard/keyboard.gyp:keyboard',
@@ -129,7 +128,8 @@
'content/delegate/app_content_control_delegate_impl.cc',
'content/public/app_content_control_delegate.h',
'content/public/app_registry.h',
- 'content/public/content_activity_factory.h',
+ 'content/content_activity_factory.h',
+ 'content/public/content_activity_factory_creator.h',
'content/public/content_app_model_builder.h',
'content/public/web_contents_view_delegate_creator.h',
'content/render_view_context_menu_impl.cc',
@@ -150,6 +150,9 @@
'../extensions/shell/app_shell.gyp:app_shell_lib',
],
'sources': [
+ 'content/shell/content_activity_factory.cc',
+ 'content/shell/shell_app_activity.cc',
+ 'content/shell/shell_app_activity.h',
'extensions/shell/extensions_delegate_impl.cc',
],
},
@@ -197,6 +200,7 @@
'dependencies': [
'../skia/skia.gyp:skia',
'../testing/gtest.gyp:gtest',
+ 'athena_app_shell_lib',
'athena_lib',
'athena_test_support',
'main/athena_main.gyp:athena_main_lib',

Powered by Google App Engine
This is Rietveld 408576698