Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: athena/activity/public/activity_factory.h

Issue 505273002: Move app_shell specific impl from athena_lib to athena_shell_lib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | athena/athena.gyp » ('j') | athena/content/app_activity_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/activity/public/activity_factory.h
diff --git a/athena/activity/public/activity_factory.h b/athena/activity/public/activity_factory.h
index cd79ca76b7c0a7b0cbdd10630085b3b1c1f57def..64d9a49acb60eec640cddf0596e6e08a00e415ef 100644
--- a/athena/activity/public/activity_factory.h
+++ b/athena/activity/public/activity_factory.h
@@ -8,6 +8,10 @@
#include "athena/athena_export.h"
#include "url/gurl.h"
+namespace apps {
+class AppWindow;
+}
+
namespace content {
class BrowserContext;
}
@@ -36,10 +40,13 @@ class ATHENA_EXPORT ActivityFactory {
virtual Activity* CreateWebActivity(content::BrowserContext* browser_context,
const GURL& url) = 0;
- // Create an activity of an app with |app_window|. The returned activity
- // should own |app_window|.
+ // Create an activity of an app with |app_window| for app shell environemnt.
+ // The returned activity should own |app_window|.
Jun Mukai 2014/08/26 21:28:23 Please comment that this method will be removed on
oshima 2014/08/26 21:43:27 Done.
virtual Activity* CreateAppActivity(
extensions::ShellAppWindow* app_window) = 0;
+
+ // Create an activity of an app with |app_window| for chrome environment.
+ virtual Activity* CreateAppActivity(apps::AppWindow* app_window) = 0;
};
} // namespace athena
« no previous file with comments | « no previous file | athena/athena.gyp » ('j') | athena/content/app_activity_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698