Update AnalysisCanvas drawRect early-exit logic to match SkCanvas.cpp again.

Update AnalysisCanvas drawRect early-exit logic to match SkCanvas.cpp again.

We're getting away without checking bounds today because we're building
and checking a bounding-box hierarchy at record time; draws outside the
picture bounds happen to never be recorded.

This isn't a guarantee of the recording API, and indeed doesn't happen if you
record without a bounding-box hierarchy.  We want to lean on this lack of
guarantee a bit more.  To cut down on time spent recording, we may move around
when we build a bounding box hierarchy.  The upshot is that the SkPicture may
contain commands that won't draw anything, and AnalysisCanvas might receive them.

In short, the safe thing to do is quickReject just like SkCanvas does.

tested: cc_unittests, unit_tests

(Background: found this when debugging PicturePileImplTest.AnalyzeIsSolid* failures from  http://crrev.com/504823003)

BUG=

Committed: https://crrev.com/ae5bc7f7a80a8d8eb2bef1fc50c2e935def19d7b
Cr-Commit-Position: refs/heads/master@{#292141}

[mtklein_C, 2014-08-26 18:13:18]

mtklein@chromium.org changed reviewers:
+ reed@google.com, reveman@chromium.org

[reed1, 2014-08-26 18:14:47]

sgtm

[reveman, 2014-08-27 00:38:04]

lgtm

[mtklein, 2014-08-27 00:45:15]

On 2014/08/27 00:38:04, reveman wrote:
> lgtm

Thanks!

[mtklein, 2014-08-27 00:45:17]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 00:46:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/505263002/1

[mtklein, 2014-08-27 01:54:30]

FYI: I've put back the paint.nothingToDraw() check, if only so that unit_tests'
AnalysisCanvasTest.SimpleDrawRect passes.  Can't see any harm in checking both.

[mtklein, 2014-08-27 01:56:40]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 01:57:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/505263002/60001

[commit-bot: I haz the power, 2014-08-27 03:28:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-27 03:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 03:35:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2014-08-27 13:17:29]

The CQ bit was checked by reed@google.com

[reed1, 2014-08-27 13:17:30]

lgtm

[commit-bot: I haz the power, 2014-08-27 13:18:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/505263002/60001

[commit-bot: I haz the power, 2014-08-27 14:23:55]

Committed patchset #4 (60001) as d304d013064aece0e3f574bcc2ba8ee2a234ac23

[commit-bot: I haz the power, 2014-09-10 02:51:18]

Patchset 4 (id:??) landed as
https://crrev.com/ae5bc7f7a80a8d8eb2bef1fc50c2e935def19d7b
Cr-Commit-Position: refs/heads/master@{#292141}